Even if he were to be pardoned for any federal crimes (which isn't implausible, even without a self-pardon) he seems pretty likely to face criminal charges in New York State and possibly, with the election extortion effort, Georgia, that are not subject to federal pardon.
Prison probably complicates a comeback campaign in 2024. (Also, even without that, he would have neither the outsider ambiguity that help him win in 2016 not the power of incumbency that helped him, but not enough to win, in 2020. He might retain enough influence with the Republican base that if he isn't disabled by legal issues he could win a nomination in 2024, but the general election seems more uphill.)
Prison probably complicates a comeback campaign in 2024. (Also, even without that, he would have neither the outsider ambiguity that help him win in 2016 not the power of incumbency that helped him, but not enough to win, in 2020. He might retain enough influence with the Republican base that if he isn't disabled by legal issues he could win a nomination in 2024, but the general election seems more uphill.)